Feed problems with 1.7.9, both still work fine on 1.7.8

Support requests, bug reports, etc. go here. Dedicated servers / VDS hosting only
mx2
Bear Rating Trainee
Bear Rating Trainee
Posts: 5
Joined: 15 May 2013, 07:31

Feed problems with 1.7.9, both still work fine on 1.7.8

Postby mx2 » 15 May 2013, 07:51

I've got two feeds which no longer work properly after the upgrade to 1.7.9:

http://menofporn.typepad.com/menofporn/atom.xml
This feed doesn't display photos anymore

http://feeds.towleroad.com/towleroad/feed
This feed I now receive an error and won't update

I have verified that both still work fine on 1.7.8... I have one machine still running that version.

If there is anymore information I can provide that will help figure it out, let me know.

Thanks!

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby fox » 15 May 2013, 09:09

Second feed is Atom 0.3, the following patch should restore compatibility with this format:

https://github.com/gothfox/Tiny-Tiny-RS ... de6f269e0a

Edit: not sure about issues with the first one, there's something strange in how domdocument handles XML there but I don't know nearly enough about this to tell you why.

linoth
Bear Rating Trainee
Bear Rating Trainee
Posts: 22
Joined: 15 May 2013, 11:34

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby linoth » 15 May 2013, 11:42

I didn't investigate to make sure that it's the actual cause, so I'm foolishly throwing out an idea and praying I don't miss. Sorry if I'm wrong, but it might answer what's wrong with the first feed.

I have a custom feed I use that 1.7.9 didn't agree with, and almost all of the content was being dropped from each item. Changing the HTML tags inside of the content section for the entries from unescaped to escaped (>) solved the problem there.

Not much mx2 can do here, and I have no idea if unescaped HTML is correct or not.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby fox » 15 May 2013, 11:53

This actually makes sense, the parser gets content node value, but if the content is not encoded, nodevalue might contain text representation of the subtree below.

phz
Bear Rating Disaster
Bear Rating Disaster
Posts: 77
Joined: 18 Mar 2013, 18:32

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby phz » 15 May 2013, 16:18

Some readers would probably appreciate a visible "NSFW" mark on the first feed. Not that the URL leaves much ambiguity, but it's still good practice.

(And by this comment, perhaps the amount of clicks on the link will skyrocket :-D )

phz
Bear Rating Disaster
Bear Rating Disaster
Posts: 77
Joined: 18 Mar 2013, 18:32

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby phz » 15 May 2013, 16:32

To the original poster, if it is not clear: the first feed is invalid XML by a large margin. The < character is not allowed to exist unescaped in XML tag content, but no escaping at all seem to be going on for the feed in question. Either it should be inside a CDATA-block or encoded with the entity "&lt;". See this section in the W3C definition.

That it worked in previous versions of TT-RSS was probably because TT-RSS then used an external library that went out of its way to try to interpret invalid XML as valid, even though this probably led to other strange behavior. Now TT-RSS uses its own parser if I understand it correctly, which isn't as lenient in parsing invalid XML.

You could always try to ask the site to start generating valid XML. It should be quite an easy task on their end, and in their own interest as well, one could imagine.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby fox » 15 May 2013, 16:38

Well, to be fair, if it's valid XML, why not. So <content> will have an XML subtree under it, it's not inherently wrong. I'm not sure if that kinda thing is allowed in Atom feeds though, at least I've never seen it before. Usually people escape content as it is not valid XML.

That it worked in previous versions of TT-RSS was probably because TT-RSS then used an external library that went out of its way to try to interpret invalid XML as valid, even though this probably led to other strange behavior. Now TT-RSS uses its own parser if I understand it correctly, which isn't as lenient in parsing invalid XML.


Yep.

mx2
Bear Rating Trainee
Bear Rating Trainee
Posts: 5
Joined: 15 May 2013, 07:31

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby mx2 » 15 May 2013, 21:16

Yep... second feed now works. Thanks!

I've communicated with the owner of the first feed several times and I'm sure he's willing to change things, but not sure what to tell him.

I ran both feeds through W3 and strangely enough, the second feed (which works now) has errors, while the first feed (which still isn't working) validates just fine:

http://validator.w3.org/feed/check.cgi? ... oad%2Ffeed - shows errors but works now

http://validator.w3.org/feed/check.cgi? ... 2Fatom.xml - Doesn't work, but the validator says: Congratulations, this is a valid Atom 1.0 feed

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby fox » 15 May 2013, 22:12

It is technically valid, it's just the content is in unexpected format. Like posted above, usually it is escaped and wrapped in a CDATA section.

mx2
Bear Rating Trainee
Bear Rating Trainee
Posts: 5
Joined: 15 May 2013, 07:31

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby mx2 » 15 May 2013, 22:26

OK... I've sent an email to the blog owner asking him to take a look. It's a typepad blog, so I would guess he is using typepad tools to auto-magically generate the feed. If that is the case,
the typepad folks will ultimately have to weigh in...

Thanks!

mx2
Bear Rating Trainee
Bear Rating Trainee
Posts: 5
Joined: 15 May 2013, 07:31

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby mx2 » 15 May 2013, 22:38

Yeah, my hunch was correct -- it is the way typepad is doing things:

http://everything.typepad.com/blog/atom.xml

Display this in ttrss 1.7.9 and it doesn't display properly, no images, text run together...

Display in Google reader and ttrss 1.7.8 and it looks fine...

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby fox » 15 May 2013, 23:07

Here's an experimental fix. I'm seeing a lot of cocks right now, so it seems that it is working.

https://github.com/gothfox/Tiny-Tiny-RS ... fe40ec0c01

Report if it breaks other feeds or whatnot.

Reader_Refugee
Bear Rating Trainee
Bear Rating Trainee
Posts: 7
Joined: 01 Apr 2013, 19:25

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby Reader_Refugee » 16 May 2013, 00:18

I'm seeing a lot of cocks right now, so it seems that it is working.


Hall of Fame material right there ;)

User avatar
dxbi
Bear Rating Disaster
Bear Rating Disaster
Posts: 62
Joined: 16 Mar 2013, 13:44

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby dxbi » 16 May 2013, 01:11

fox wrote:It is technically valid, it's just the content is in unexpected format. Like posted above, usually it is escaped and wrapped in a CDATA section.


If I understand the RFC correctly, type=xhtml is expected not to be escaped: http://tools.ietf.org/html/rfc4287#section-3.1.1

User avatar
dxbi
Bear Rating Disaster
Bear Rating Disaster
Posts: 62
Joined: 16 Mar 2013, 13:44

Re: Feed problems with 1.7.9, both still work fine on 1.7.8

Postby dxbi » 16 May 2013, 01:29

Just noticed that feeds from Gitlab broke in pretty much the same way but while the dick feed appears to be working, this feed still has no markup: http://www.stunet.tu-freiberg.de/~eckho ... board.atom


Return to “Support”

Who is online

Users browsing this forum: No registered users and 10 guests