Page 1 of 1

Next Article hotkey doesn't work as expected while scrolling

Posted: 15 May 2013, 23:25
by Larrypoppins
Not sure if this is a problem with my install, a feature request, or as-designed.

Behavior:
('Automatically mark articles as read' and 'combined feed display')
scrolling past articles marks them as read, but if the user then uses a hotkey like J, the article list jumps to the top-most article (or the last article they J'd past).

Expected behavior:
after scrolling past articles, which are being marked as read, a hotkey like J should advance to the next article after the one that is currently being viewed. J should not move to the top of the article list (or the last J'd or N'd past).

Am I crazy? Is my shit broken? Or is that how it works?

The use case is obvious, right? Sometimes I scroll, sometimes I J it. It's how I roll.

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 15 May 2013, 23:32
by fox
yeah at the moment just click on a visible article before doing j to set a reference point, it's a known thing

Sent from my Nexus 7 using Tapatalk HD

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 16 May 2013, 00:46
by Larrypoppins
Cool. Thanks.

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 16 May 2013, 09:54
by fox
This has actually been (slightly) annoying me for years, but I was too lazy to do something about it.

https://github.com/gothfox/Tiny-Tiny-RS ... f2f71a6e03

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 16 May 2013, 10:00
by sleeper_service
fox wrote:This has actually been (slightly) annoying me for years, but I was too lazy to do something about it.

https://github.com/gothfox/Tiny-Tiny-RS ... f2f71a6e03


thanks, it's been annoying me for a while, but I was too lazy to post anything about it.

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 16 May 2013, 10:08
by sleeper_service
though, not to be mr picky, but shouldn't it mark the article read *after* it scrolls out of the window, not the instant the top of the article scrolls into the bottom of the window?

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 16 May 2013, 10:30
by fox
I don't think it auto marks active article as read, it just selects it so hotkeys would have a reference point. You still need to either click on it or scroll down to mark it as read.

Edit: you can see that in expanded mode auto selected headline is not blue it becomes when you click on it and it marks as read, it's still black, e.g. unread.

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 16 May 2013, 10:42
by sleeper_service
I'm watching, in expanded mode, the checkbox on the upper left, as soon as article a hit's the top, article b below it gets checked. if article a is longer than the screen, article b gets checked as soon as, if not before, it hits the bottom of the screen, if I then hit the hotkey, I get article c, missing b.

I think it should select it after it's scrolled off the screen, so if I then hit the hotkey, it scrolls to the next, not scrolled off article.

I think I read somewhere that articles should be marked as read when they've scrolled off the page, perhaps this should select the same way?

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 16 May 2013, 10:51
by fox

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 17 May 2013, 00:31
by sleeper_service
yeah, nice. I haven't seen it skip any articles switching between scrolling and hotkeys.

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 17 May 2013, 00:53
by Larrypoppins
Wow, sweet.

Can I simply make those edits to my viewfeed.js? I'm running 1.7.9.

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 17 May 2013, 01:03
by fox
Yes, it should work fine.

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 17 May 2013, 03:10
by sleeper_service
Larrypoppins wrote:Wow, sweet.

Can I simply make those edits to my viewfeed.js? I'm running 1.7.9.


I'd suggest looking into running trunk via git clone/git pull, it really is much nicer, plus you get fox's new teaks and improvements faster ;)

Re: Next Article hotkey doesn't work as expected while scrol

Posted: 19 Jun 2013, 09:28
by timop
should this next article hotkey to be work in 1.8 version ?
it doesnt, it just reads next article but wont scroll.

edit: I tested with default theme and scrolling works, something wrong with "And yet another google reader theme"
viewtopic.php?f=22&t=2178