[1.8] Error when collapsing feedlist (<< button)

Support requests, bug reports, etc. go here. Dedicated servers / VDS hosting only
User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

[1.8] Error when collapsing feedlist (<< button)

Postby fox » 13 Jun 2013, 14:53

E.g. when clicking on a "<<" button in the toolbar.

Fix: https://github.com/gothfox/Tiny-Tiny-RS ... 42e4f583a8

Known issue: sidebar is visible and you can drag it around for mildly amusing results, I'll fix this later.

levito
Bear Rating Disaster
Bear Rating Disaster
Posts: 77
Joined: 17 Mar 2013, 04:18

Re: [1.8] Error when collapsing feedlist (<< button)

Postby levito » 14 Jul 2013, 23:20

The bug is still there... But I found out when it happens:

The bug was introduced when you added the floating title, short time before v1.8 was released.

As soon as the floating title is shown (both combined views), the error is triggered when you collapse the feed list.
Changing feeds hides the floating title => everything works fine.
Scroll down to show the floating title => it's there again.

Another side effect: The width of the headline frame won't be adjusted after collapsing the feed list.

My Setup: Chrome 28 and Firefox 22 on Mac OS X 10.8.4, TT-RSS from GitHub, commit 9e2d513dbd63486e9b6823d36b8c49adbb80fb45

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: [1.8] Error when collapsing feedlist (<< button)

Postby fox » 15 Jul 2013, 05:15


levito
Bear Rating Disaster
Bear Rating Disaster
Posts: 77
Joined: 17 Mar 2013, 04:18

Re: [1.8] Error when collapsing feedlist (<< button)

Postby levito » 15 Jul 2013, 12:16

Thanks, this does the trick!

Why did you hide the collapse button in commit 618e80ee5e8757d2ecdd8fb21f89cf7385b663ee? Are there any other issues?

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: [1.8] Error when collapsing feedlist (<< button)

Postby fox » 15 Jul 2013, 14:25

I don't think it's needed much anymore, there's a hotkey and you can adjust the column for whatever width which will be remembered.

Also I don't think it's used much (it was broken for at least one milestone and nobody noticed) so I figured deemphasizing it further to clean up the toolbar is a good idea. You can still user-css enable it.

levito
Bear Rating Disaster
Bear Rating Disaster
Posts: 77
Joined: 17 Mar 2013, 04:18

Re: [1.8] Error when collapsing feedlist (<< button)

Postby levito » 15 Jul 2013, 19:22

Perfect! Cleaning up stuff is always a good idea. I'll re-enable it in my theme css.

roshambo
Bear Rating Trainee
Bear Rating Trainee
Posts: 35
Joined: 19 Jun 2013, 20:03

Re: [1.8] Error when collapsing feedlist (<< button)

Postby roshambo » 23 Jul 2013, 05:39

What is the css to enable it?

Most used button on the toolbar here and regularly without a keyboard so 'c s' isn't really a replacement. I never considered other rss readers because they lacked the ability to collapse the feed list. TTRSS's toolbar has a lot of whitespace on it when feedlist is collapsed, keeping this button and having some nice native looking buttons for feed navigating, subscribing, etc. would be a better direction imo. The article_toolbar plugin adds this functionality but the buttons look tacked on as if they don't belong.

This thread already existed when I started using ttrss so I didn't say anything about it and waited for a fix but noticed the problem within the first minute.

Anyhow the button would be much less useful to me if it would save the state of the feedlist in a cookie like other rss readers are doing. In the future maybe?

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: [1.8] Error when collapsing feedlist (<< button)

Postby fox » 23 Jul 2013, 06:01


AngryChris
Bear Rating Master
Bear Rating Master
Posts: 135
Joined: 08 Apr 2013, 02:42

Re: [1.8] Error when collapsing feedlist (<< button)

Postby AngryChris » 23 Jul 2013, 06:05


roshambo
Bear Rating Trainee
Bear Rating Trainee
Posts: 35
Joined: 19 Jun 2013, 20:03

Re: [1.8] Error when collapsing feedlist (<< button)

Postby roshambo » 23 Jul 2013, 08:19


User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: [1.8] Error when collapsing feedlist (<< button)

Postby fox » 23 Jul 2013, 08:33

>That was my first attempt before trying to find an answer before posting, it doesn't work.

Well, eh. The specified display : none might be overriding it. Well, it's easily solved with a plugin.
Attachments
show_collapse.zip
(789 Bytes) Downloaded 126 times

levito
Bear Rating Disaster
Bear Rating Disaster
Posts: 77
Joined: 17 Mar 2013, 04:18

Re: [1.8] Error when collapsing feedlist (<< button)

Postby levito » 23 Jul 2013, 20:17



Return to “Support”

Who is online

Users browsing this forum: No registered users and 11 guests