Page 1 of 1

[1.8] Error when collapsing feedlist (<< button)

Posted: 13 Jun 2013, 14:53
by fox
E.g. when clicking on a "<<" button in the toolbar.

Fix: https://github.com/gothfox/Tiny-Tiny-RS ... 42e4f583a8

Known issue: sidebar is visible and you can drag it around for mildly amusing results, I'll fix this later.

Re: [1.8] Error when collapsing feedlist (<< button)

Posted: 14 Jul 2013, 23:20
by levito
The bug is still there... But I found out when it happens:

The bug was introduced when you added the floating title, short time before v1.8 was released.

As soon as the floating title is shown (both combined views), the error is triggered when you collapse the feed list.
Changing feeds hides the floating title => everything works fine.
Scroll down to show the floating title => it's there again.

Another side effect: The width of the headline frame won't be adjusted after collapsing the feed list.

My Setup: Chrome 28 and Firefox 22 on Mac OS X 10.8.4, TT-RSS from GitHub, commit 9e2d513dbd63486e9b6823d36b8c49adbb80fb45

Re: [1.8] Error when collapsing feedlist (<< button)

Posted: 15 Jul 2013, 05:15
by fox

Re: [1.8] Error when collapsing feedlist (<< button)

Posted: 15 Jul 2013, 12:16
by levito
Thanks, this does the trick!

Why did you hide the collapse button in commit 618e80ee5e8757d2ecdd8fb21f89cf7385b663ee? Are there any other issues?

Re: [1.8] Error when collapsing feedlist (<< button)

Posted: 15 Jul 2013, 14:25
by fox
I don't think it's needed much anymore, there's a hotkey and you can adjust the column for whatever width which will be remembered.

Also I don't think it's used much (it was broken for at least one milestone and nobody noticed) so I figured deemphasizing it further to clean up the toolbar is a good idea. You can still user-css enable it.

Re: [1.8] Error when collapsing feedlist (<< button)

Posted: 15 Jul 2013, 19:22
by levito
Perfect! Cleaning up stuff is always a good idea. I'll re-enable it in my theme css.

Re: [1.8] Error when collapsing feedlist (<< button)

Posted: 23 Jul 2013, 05:39
by roshambo
What is the css to enable it?

Most used button on the toolbar here and regularly without a keyboard so 'c s' isn't really a replacement. I never considered other rss readers because they lacked the ability to collapse the feed list. TTRSS's toolbar has a lot of whitespace on it when feedlist is collapsed, keeping this button and having some nice native looking buttons for feed navigating, subscribing, etc. would be a better direction imo. The article_toolbar plugin adds this functionality but the buttons look tacked on as if they don't belong.

This thread already existed when I started using ttrss so I didn't say anything about it and waited for a fix but noticed the problem within the first minute.

Anyhow the button would be much less useful to me if it would save the state of the feedlist in a cookie like other rss readers are doing. In the future maybe?

Re: [1.8] Error when collapsing feedlist (<< button)

Posted: 23 Jul 2013, 06:01
by fox
Try the following user css:

Code: Select all

#collapse_feeds_btn { display : inline ! important; }


e:

>if it would save the state of the feedlist in a cookie

good idea, please create a ticket for this so I wouldn't forget

Re: [1.8] Error when collapsing feedlist (<< button)

Posted: 23 Jul 2013, 06:05
by AngryChris
roshambo wrote:The article_toolbar plugin adds this functionality but the buttons look tacked on as if they don't belong.

I don't care for article_toolbar either for the same reason. But I really like article_toolbar_small. Have you given that one a try? It fits right in (IMO).

Re: [1.8] Error when collapsing feedlist (<< button)

Posted: 23 Jul 2013, 08:19
by roshambo
fox wrote:Try the following user css:

Code: Select all

#collapse_feeds_btn { display : inline ! important; }



That was my first attempt before trying to find an answer before posting, it doesn't work.

>if it would save the state of the feedlist in a cookie

good idea, please create a ticket for this so I wouldn't forget


http://tt-rss.org/redmine/projects/tt-rss/issues here? Does it need a different login?

AngryChris wrote:
roshambo wrote:The article_toolbar plugin adds this functionality but the buttons look tacked on as if they don't belong.

I don't care for article_toolbar either for the same reason. But I really like article_toolbar_small. Have you given that one a try? It fits right in (IMO).


Yup that what I use, the images are offset and not appealing. Found some other images that look better (to me) and was able to get them aligned but still not visually appealing.

Re: [1.8] Error when collapsing feedlist (<< button)

Posted: 23 Jul 2013, 08:33
by fox
>That was my first attempt before trying to find an answer before posting, it doesn't work.

Well, eh. The specified display : none might be overriding it. Well, it's easily solved with a plugin.

Re: [1.8] Error when collapsing feedlist (<< button)

Posted: 23 Jul 2013, 20:17
by levito
There is no ID on the button. So, to show it, you currently need something like this:

Code: Select all

#main_toolbar_form > .dijitButton {
    display: inline-block !important;
}


An ID would be nice though.