After upgrade to 1.13, 'j' moves to next category

Support requests, bug reports, etc. go here. Dedicated servers / VDS hosting only
nkowalski
Bear Rating Trainee
Bear Rating Trainee
Posts: 5
Joined: 23 Jul 2014, 10:32

After upgrade to 1.13, 'j' moves to next category

Postby nkowalski » 23 Jul 2014, 10:41

Hello,

Since I upgraded my installation to v1.13, I noticed that when I change to the next category with unread articles (by hitting 'f', 'q'), then begin to read articles within it (by hitting 'j'), tiny tiny rss switches to the next category with unread articles; said another way, hitting 'f', 'q' then 'j' makes switch category from n to N+2.

I use the plugin googlereaderkeys if that does matter.

Is that behaviour intended ?

Thanks,
Nicolas.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: After upgrade to 1.13, 'j' moves to next category

Postby fox » 23 Jul 2014, 10:56

I've merged a thing that auto-opens the next category/feed if you have auto mark as read and on catchup open next preferences enabled: https://github.com/gothfox/Tiny-Tiny-RSS/pull/386

Maybe there's a race condition there with the manual hotkey so it opens twice in some cases. Try commenting out the last green block and see if it helps:

https://github.com/wolfgangasdf/Tiny-Ti ... 5cb2537663

I.e. the lines 1402-1407

nkowalski
Bear Rating Trainee
Bear Rating Trainee
Posts: 5
Joined: 23 Jul 2014, 10:32

Re: After upgrade to 1.13, 'j' moves to next category

Postby nkowalski » 23 Jul 2014, 12:37

Yes, it helps. With the lines 1402-1407 commented out, I have the same behaviour than before 1.13.

Thanks a lot!

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: After upgrade to 1.13, 'j' moves to next category

Postby fox » 23 Jul 2014, 13:02

I'm gonna link this to the pull author, maybe he'll figure the proper solution.

wolfgangasdf
Bear Rating Trainee
Bear Rating Trainee
Posts: 5
Joined: 23 Jul 2014, 18:16

Re: After upgrade to 1.13, 'j' moves to next category

Postby wolfgangasdf » 23 Jul 2014, 18:37

Hi,I have tried to reproduce your error but I failed so far... Since there is a large number of possible combinations of settings, could you please send me your settings? Probably easiest via settings->feeds->opml: export with settings, you can strip your feeds or not. Or screenshot of the settings page. You can email this to me: [email protected].

The 'green' section is only activated if (i) mark articles read automatically is enabled (cdm_auto_catchup) (ii) auto-show next feed on catchup is enabled (on_catchup_show_next_feed) (iii) you scroll the list while there are no unread articles left.

I find the auto-show of next feed/category after scrolling over all articles extremely useful, and will try hard to keep it in!

nkowalski
Bear Rating Trainee
Bear Rating Trainee
Posts: 5
Joined: 23 Jul 2014, 10:32

Re: After upgrade to 1.13, 'j' moves to next category

Postby nkowalski » 23 Jul 2014, 20:42

I sent you an OPML export of my settings by mail.

Thanks for your help.

nameless
Bear Rating Master
Bear Rating Master
Posts: 126
Joined: 28 Aug 2013, 20:33

Re: After upgrade to 1.13, 'j' moves to next category

Postby nameless » 24 Jul 2014, 04:17

Can't this be worked around by adding a button (similar to levitos feedly theme) pretty easily?
I don't how easy this can be done with dojo though due to the fact I know cloe to nothing about this framework.

wolfgangasdf
Bear Rating Trainee
Bear Rating Trainee
Posts: 5
Joined: 23 Jul 2014, 18:16

Re: After upgrade to 1.13, 'j' moves to next category

Postby wolfgangasdf » 25 Jul 2014, 11:37

Attached is a tiny patch against 1.13 that seems to resolve the issue, thanks to nkowalski for help! The feature is now removed from git trunk. As I find the feature (jump to next unread category/feed after all articles have been made read by scrolling over them, avoids clicking every time 'go to next category/feed') very useful, and I don't know a proper solution, I will maintain it here:
https://github.com/wolfgangasdf/Tiny-Tiny-RSS
Attachments
fix.patch
patch against 1.13 to resolve jumping over cat/feed
(666 Bytes) Downloaded 73 times

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: After upgrade to 1.13, 'j' moves to next category

Postby fox » 25 Jul 2014, 11:46

I think it would be better if you didn't change feeds in catchup callback since it works independent of UI-actions on a timeout.

So you can collect w/e in headlines onscroll handler and switch feeds there synchronously? I think.

I'm not against this feature or anything I just have problems with current implementation. When those are resolved I'll merge it back.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: After upgrade to 1.13, 'j' moves to next category

Postby fox » 25 Jul 2014, 12:14

What about this? I'm not sure it works properly, please report back:

https://github.com/gothfox/Tiny-Tiny-RS ... db1264b864

e: also https://github.com/gothfox/Tiny-Tiny-RS ... 3957bc97f8

nkowalski
Bear Rating Trainee
Bear Rating Trainee
Posts: 5
Joined: 23 Jul 2014, 10:32

Re: After upgrade to 1.13, 'j' moves to next category

Postby nkowalski » 25 Jul 2014, 12:30

The problem I encountered (switch from category n to N+2) does not appear with that patch.

For my knowledge, what is now the expected behaviour? Hitting 'j' after reading the last article of a category should make ttrss switch to the next category with unread items?

e: also applied the second patch, works well.
Last edited by nkowalski on 25 Jul 2014, 12:36, edited 1 time in total.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: After upgrade to 1.13, 'j' moves to next category

Postby fox » 25 Jul 2014, 12:34

The point of this is that you can just keep scrolling down and it will auto-open next unread thing for you. I guess feedly does that or something.

Hotkey-based operation should not be affected it's just that you may not need to press "j" at all. You can also disable "on catchup show next" and disable it altogether, if you press f-q j it shouldn't be necessary anyway

e: maybe it's better to create some clickable thing like "looks like we're finished here, open next feed?" instead of doing this automatically because it might be confusing.

dariottolo
Bear Rating Trainee
Bear Rating Trainee
Posts: 27
Joined: 05 Jul 2014, 18:57

Re: After upgrade to 1.13, 'j' moves to next category

Postby dariottolo » 25 Jul 2014, 14:32

I don't know if it helps, but I noticed that while I am reading (scrolling) a very long article, the next unread feed will be open in the middle, not allowing me to finish reading it.

Is it just me?

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: After upgrade to 1.13, 'j' moves to next category

Postby fox » 25 Jul 2014, 14:45

It currently fires at 50% threshold of shit being scrolled up, maybe this should be adjusted in this case for long articles.

e: adjusted in trunk

nameless
Bear Rating Master
Bear Rating Master
Posts: 126
Joined: 28 Aug 2013, 20:33

Re: After upgrade to 1.13, 'j' moves to next category

Postby nameless » 25 Jul 2014, 16:05

Work fine, but feels kinda like a foreign object in ttrss.
I can't come up with a more sufficient styling though. Rebuilding the feedly the end button would feel most native i guess.


Return to “Support”

Who is online

Users browsing this forum: No registered users and 12 guests