Bug when displaying image attachments

Support requests, bug reports, etc. go here. Dedicated servers / VDS hosting only
linoth
Bear Rating Trainee
Bear Rating Trainee
Posts: 22
Joined: 15 May 2013, 11:34

Bug when displaying image attachments

Postby linoth » 23 Aug 2015, 19:39

I wish my knowledge of git was a little more solid so I could offer patches or any of that good stuff, but thankfully this one looks pretty simple to describe and I even tested.

When displaying image attachments, it seems that the height and width values are being swapped for my feeds.

It looks like these are handled on /include/functions2.php, lines 1956 and 1958, and switching the values on my instance corrected the issue. Note that "height" is being given the "width" item from the $entry array and vice versa.

Is there a use case where the swap is correct?

JustAMacUser
Bear Rating Overlord
Bear Rating Overlord
Posts: 373
Joined: 20 Aug 2013, 23:13

Re: Bug when displaying image attachments

Postby JustAMacUser » 23 Aug 2015, 20:12

Not sure what the use-case would be, fox can add his thoughts, but I've submitted a patch to assign width to width, etc.

https://tt-rss.org/gitlab/fox/tt-rss/merge_requests/12

e: Patched has been merged. A git pull should get things working for you. Thanks for pointing this out and thanks to fox for the quick merge.


Return to “Support”

Who is online

Users browsing this forum: No registered users and 12 guests