Problem with "Mark updated articles as unread"

Support requests, bug reports, etc. go here. Dedicated servers / VDS hosting only
LoCoRoCo
Bear Rating Trainee
Bear Rating Trainee
Posts: 11
Joined: 23 Jul 2013, 14:37

Problem with "Mark updated articles as unread"

Postby LoCoRoCo » 04 Dec 2015, 10:30

Hello,

has anyone else a problem with the "Mark updated articles as unread" function? It seems to detect all entrys in the current feed as "updated" and mark the as unreaded on every reload. In the source code I can not find any algorithm that handles this properly.

Thanks

martywd
Bear Rating Trainee
Bear Rating Trainee
Posts: 26
Joined: 04 Feb 2013, 20:47
Location: Texas

Re: Problem with "Mark updated articles as unread"

Postby martywd » 04 Dec 2015, 22:27

LoCoRoCo wrote:Hello,

has anyone else a problem with the "Mark updated articles as unread" function? It seems to detect all entrys in the current feed as "updated" and mark the as unreaded on every reload. In the source code I can not find any algorithm that handles this properly.

Thanks


I didn't have this 'Options' enabled on any of feeds, but did enable 'Mark updated articles as unread' today on a couple of subscribtions, this tt-rss forum being one of them. I see the same issue you type of. With 'Mark updated articles as unread' ticked, read articles recent and months old reappear on the next scheduled update of the subscribe feed. Mark them 'read', on the nex update those articles are back again, _un-read_.
.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Problem with "Mark updated articles as unread"

Postby fox » 05 Dec 2015, 02:54

yeah looks like something is not right there, some posts can get this function confused a bit.

e: well to give one obvious example, one of active posts on this forum (by ptsa, the E_WARNING thread) links an attached image which phpbb embeds with a different ?sid=xxx parameter every time. i guess it would be more reliable to strip tags when calculating article checksum because of stuff like this.

Code: Select all

<img src="https://tt-rss.org/forum/download/file.php?id=849&amp;sid=2c1e610932ece72ccd325b663ca11cc8" class="postimage"


e2: this seems to be more reliable if we operate on article text only. this might not catch some updated articles, i guess, but there should be way less annoying false positives, also more reliable hashing means less cpu time spent processing stuff again and again.

LoCoRoCo
Bear Rating Trainee
Bear Rating Trainee
Posts: 11
Joined: 23 Jul 2013, 14:37

Re: Problem with "Mark updated articles as unread"

Postby LoCoRoCo » 07 Dec 2015, 11:42

One of the feeds with the problem ist http://feeds.feedburner.com/blogspot/Tmnu. But, every time i reload, the text is content (and checksume) is the same. i enable debuging and i can see that the checksumme is the same, but it get unreaded...

For me, it seems that mark_unread_on_update runs every time the feed with this option is processed...

Code: Select all

[08:39:44/28101] start
[08:39:44/28101] local cache will not be used for this feed
[08:39:44/28101] fetching [http://feeds.feedburner.com/blogspot/Tmnu]...
[08:39:44/28101] If-Modified-Since: Mon, 23 Nov 2015 00:40:00 GMT
[08:39:44/28101] fetch done.
[08:39:44/28101] saving cache/simplepie/a225126f385b522eff8595c39d654984d9d9515a.xml
[08:39:44/28101] language: english
[08:39:44/28101] processing feed data...
[08:39:44/28101] site_url: http://portableappz.blogspot.com/
[08:39:44/28101] feed_title: PortableAppZ
[08:39:44/28101] loading filters & labels...
[08:39:44/28101] 0 filters loaded.
[08:39:44/28101] processing articles...
[08:39:44/28101] guid 1,tag:blogger.com,1999:blog-4710718600867058437.post-4970493029269676790 / SHA1
:a4b79e3e1b3e23a45c9ec815f7124cc57b703491
[08:39:44/28101] orig date: 1449164956
[08:39:44/28101] date 1449164956 [2015/12/03 17:49:16]
[08:39:44/28101] title Light Image Resizer 4.7.6.0 Multilingual
[08:39:44/28101] link http://feedproxy.google.com/~r/blogspot/Tmnu/~3/FdMa2skJPmQ/light-image-resizer-4760-multilingual
.html
[08:39:44/28101] author Bernat
[08:39:44/28101] num_comments: 14
[08:39:44/28101] looking for tags...
[08:39:44/28101] tags found: graphic
[08:39:44/28101] done collecting data.
[08:39:44/28101] article hash: 3284b2b3f99ea4fc6c61feba40b596ebca8cba06 [stored=3284b2b3f99ea4fc6c61feba40b596ebca8cba06
]
[08:39:44/28101] stored article seems up to date [IID: 36608], updating timestamp only
[08:39:44/28101] hash differs, applying plugin filters:
[08:39:44/28101] plugin data:
[08:39:44/28101] article filters:
[08:39:44/28101] article labels:
Array
(
)
[08:39:44/28101] force catchup:
[08:39:44/28101] base guid found, checking for user record
[08:39:44/28101] initial score: 0 [including plugin modifier: 0]
[08:39:44/28101] user record FOUND
[08:39:44/28101] RID: 36608, IID: 36640
[08:39:44/28101] assigning labels [other]...
[08:39:44/28101] assigning labels [filters]...
[08:39:44/28101] looking for enclosures...
[08:39:44/28101] article enclosures:
Array
(
    [0] => Array
        (
            [0] => http://2.bp.blogspot.com/-1gJsif9Egjs/VgxeUNx4bfI/AAAAAAAAAMg/jbzsEr4-sdo/s72-c/ImageResizer
.png
            [1] => image/generic
            [2] =>
            [3] =>
            [4] => 72
            [5] => 72
        )

)
[08:39:44/28101] filtered article tags:
Array
(
    [0] => graphic
)
[08:39:44/28101] article processed

LoCoRoCo
Bear Rating Trainee
Bear Rating Trainee
Posts: 11
Joined: 23 Jul 2013, 14:37

Re: Problem with "Mark updated articles as unread"

Postby LoCoRoCo » 06 Jan 2016, 16:42

No one has an idea? :(

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Problem with "Mark updated articles as unread"

Postby fox » 06 Jan 2016, 17:21

guaranteeing everything to work with any random feed out there is more or less impossible

that said ever since the patch this seems to work like it should for me

e: also your log doesn't show the message that is logged when updated article is marked as unread. do you even have an uptodate tt-rss version? it could be a different problem if you do.

LoCoRoCo
Bear Rating Trainee
Bear Rating Trainee
Posts: 11
Joined: 23 Jul 2013, 14:37

Re: Problem with "Mark updated articles as unread"

Postby LoCoRoCo » 07 Jan 2016, 20:40

I have the problem with all feeds. The Logs says "[08:39:44/28101] stored article seems up to date [IID: 36608], updating timestamp only" but it set the artivle to unread...

LoCoRoCo
Bear Rating Trainee
Bear Rating Trainee
Posts: 11
Joined: 23 Jul 2013, 14:37

Re: Problem with "Mark updated articles as unread"

Postby LoCoRoCo » 07 Jan 2016, 21:02

Problem found. I set ALLOW_DUPLICATE_POSTS to false and now it working (in the GUI).

Code: Select all

                    // if we allow duplicate posts, we have to continue to
                    // create the user entries for this feed
                    if (!get_pref("ALLOW_DUPLICATE_POSTS", $owner_uid, false)) {
                        continue;
                    }

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Problem with "Mark updated articles as unread"

Postby fox » 07 Jan 2016, 21:15

which ttrss version are you running?

LoCoRoCo
Bear Rating Trainee
Bear Rating Trainee
Posts: 11
Joined: 23 Jul 2013, 14:37

Re: Problem with "Mark updated articles as unread"

Postby LoCoRoCo » 07 Jan 2016, 21:18

15.7

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Problem with "Mark updated articles as unread"

Postby fox » 07 Jan 2016, 21:20

full version including the git commit ffs

e: nvm

LoCoRoCo
Bear Rating Trainee
Bear Rating Trainee
Posts: 11
Joined: 23 Jul 2013, 14:37

Re: Problem with "Mark updated articles as unread"

Postby LoCoRoCo » 07 Jan 2016, 21:32

ffs?
e: nvm?

LoCoRoCo
Bear Rating Trainee
Bear Rating Trainee
Posts: 11
Joined: 23 Jul 2013, 14:37

Re: Problem with "Mark updated articles as unread"

Postby LoCoRoCo » 07 Jan 2016, 21:36

imo the problem is the procedure. when ALLOW_DUPLICATE_POSTS is activated, the loop isn't exit when an artivle hast the same hash. and then, it get unread every time. try it...

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Problem with "Mark updated articles as unread"

Postby fox » 07 Jan 2016, 21:38

that's the gist of it, yep

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Problem with "Mark updated articles as unread"

Postby fox » 07 Jan 2016, 21:51

well, i did poke at things, and 4f186b1 should fix the above issue.

e: also, i'm not really sure if the allow duplicate articles option is worth having in the first place. having deduplication imo is something that always makes sense, why read same stuff multiple times. also, there's multiple non-obvious/confusing things wrt the way duplicate articles are handled in tt-rss internally.

if someone can demonstrate a proper case for this option i might revert the axing but so far i'm not really seeing any point.


Return to “Support”

Who is online

Users browsing this forum: No registered users and 13 guests