"Toggle Un/read" results in undefined ref_id after commit c8919d6

Support requests, bug reports, etc. go here. Dedicated servers / VDS hosting only
User avatar
digitalcircuit
Bear Rating Trainee
Bear Rating Trainee
Posts: 8
Joined: 25 Jan 2017, 03:05

"Toggle Un/read" results in undefined ref_id after commit c8919d6

Postby digitalcircuit » 16 Feb 2017, 20:18


User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: "Toggle Un/read" results in undefined ref_id after commit c8919d6

Postby fox » 16 Feb 2017, 20:52

the only recent change related to context menu was this: https://tt-rss.org/gitlab/fox/tt-rss/co ... f936956f15

it could've broke this but unfortunately i can't reproduce your problem. can you post a screenshot and elaborate on what exactly and where you're clicking?

also, open browser error console and see if there's anything of interest there.

e: i have no idea how to use git bisect so usually i just checkout some earlier changeset, see if stuff starts working and go from there.

e2: also try emptying javascript cache

User avatar
digitalcircuit
Bear Rating Trainee
Bear Rating Trainee
Posts: 8
Joined: 25 Jan 2017, 03:05

Re: "Toggle Un/read" results in undefined ref_id after commit c8919d6

Postby digitalcircuit » 17 Feb 2017, 04:36


User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: "Toggle Un/read" results in undefined ref_id after commit c8919d6

Postby fox » 17 Feb 2017, 08:33

looks like something specific to widescreen mode, i think

e: the way menu row id was identified wasn't working quite right on widescreen mode. i've changed it as per dijit documentation and it seems to be working properly now. not sure why it was implemented this way in the first place tbh, maybe because of some old dojo version years ago (or maybe because i couldn't figure out how to do this properly).

User avatar
digitalcircuit
Bear Rating Trainee
Bear Rating Trainee
Posts: 8
Joined: 25 Jan 2017, 03:05

Re: "Toggle Un/read" results in undefined ref_id after commit c8919d6

Postby digitalcircuit » 17 Feb 2017, 21:47

I've tried a variety of articles and scrolling, and all seems to work properly. If the SQL error returns, I'll file a separate issue; for now, I'll assume it was caused by the menu issues.

Thank you for looking into this!


Return to “Support”

Who is online

Users browsing this forum: No registered users and 7 guests