Page 1 of 1

Showing feed icon to the left of the feed?

Posted: 12 Jan 2012, 13:27
by amit
Hello,

I subscribe to a lot of feeds, and generally read the 'All Articles' or 'Fresh Feeds' categories. In this case, showing the feed icon to the left of the feed would be much faster for me to check which source the feed is coming from. The default of putting in the right needs the eyes to travel quite some distance (on a big monitor), and also away from the content :)

Re: Showing feed icon to the left of the feed?

Posted: 12 Jan 2012, 14:29
by fox
This is the sort of thing you can easily hack for yourself. It is open source after all. :)

Re: Showing feed icon to the left of the feed?

Posted: 17 Feb 2012, 16:26
by amit
Thanks; as with the previous one, pointers would help.

Re: Showing feed icon to the left of the feed?

Posted: 14 Nov 2012, 14:22
by andreim
I would like to bump this, any pointer?

Re: Showing feed icon to the left of the feed?

Posted: 21 Feb 2013, 16:43
by fox
Sorry, missed this. It's very easy, what you need to do (for 3 panel mode, for example) is just move the bit of code that posts the icon upwards a bit.

E.g.

Code: Select all

diff --git a/classes/feeds.php b/classes/feeds.php
index 40e7648..4319a6c 100644
--- a/classes/feeds.php
+++ b/classes/feeds.php
@@ -445,6 +445,17 @@ class Feeds extends Handler_Protected {
               $reply['content'] .= "$marked_pic";^M
               $reply['content'] .= "$published_pic";^M
 ^M
+              if ($line["feed_title"] && !get_pref($this->link, 'VFEED_GROUP_BY_FEED')) {^M
+^M
+                 $reply['content'] .= "<span onclick=\"viewfeed($feed_id)\"^M
+                    style=\"cursor : pointer\"^M
+                    title=\"".htmlspecialchars($line['feed_title'])."\">^M
+                    $feed_icon_img<span>";^M
+              }^M
+^M
+^M
+^M
+^M
               $reply['content'] .= "</div>";^M
 ^M
               $reply['content'] .= "<div onclick='return hlClicked(event, $id)'^M
@@ -481,14 +492,6 @@ class Feeds extends Handler_Protected {
 ^M
               $reply['content'] .= $score_pic;^M
 ^M
-              if ($line["feed_title"] && !get_pref($this->link, 'VFEED_GROUP_BY_FEED')) {^M
-^M
-                 $reply['content'] .= "<span onclick=\"viewfeed($feed_id)\"^M
-                    style=\"cursor : pointer\"^M
-                    title=\"".htmlspecialchars($line['feed_title'])."\">^M
-                    $feed_icon_img<span>";^M
-              }^M
-^M
               $reply['content'] .= "</div>";^M
               $reply['content'] .= "</div>";^M
 ^M


Essentially you cut the

Code: Select all

               if ($line["feed_title"] && !get_pref($this->link, 'VFEED_GROUP_BY_FEED')) {

                  $reply['content'] .= "<span onclick=\"viewfeed($feed_id)\"
                     style=\"cursor : pointer\"
                     title=\"".htmlspecialchars($line['feed_title'])."\">
                     $feed_icon_img<span>";
               }


and paste it after published_pic, selection checkbox on at whatever other place in the hlLeft block.

Re: Showing feed icon to the left of the feed?

Posted: 19 Jun 2014, 03:12
by emanresu
Ok, I give up.

I assume the change is supposed to be made in feeds.php and that the code changed a bit over time because it looks slightly different.
Starting at line 496:

Code: Select all

               if ($line["feed_title"] && !$vfeed_group_enabled) {

                  $reply['content'] .= "<span onclick=\"viewfeed($feed_id)\"
                     style=\"cursor : pointer\"
                     title=\"".htmlspecialchars($line['feed_title'])."\">
                     $feed_icon_img<span>";
               }


Now I cut this code and paste it "after published_pic". Line 362 looked like a good place to me. But that was wrong. I tried it at several other placed before and after published_pic but it either didn't cause any visible change at all or it looked like this:
Image
And yes, I definitely cut that code. No clue why the icon appears left and right now.
I just want it left of the title.

Re: Showing feed icon to the left of the feed?

Posted: 06 Dec 2014, 01:39
by emanresu
I still couldn't figure it out. Is it even still possible?