Page 1 of 1

Don't catchup new feed or manually updated feed

Posted: 11 Apr 2012, 20:51
by gmargo
When a new feed is added, the "update_rss_feed_real()" function calls the "catchup_feed()" function, such that the newly added feed appears to have no unread articles. I don't understand the reason for this. Since I haven't read those 20 or 30 initial articles, I want to see them marked as unread instead of read.

When I was patching that, I realized this is also an issue for a "Manual Update". Since "Manual Update" sets the last_updated field to NULL (just like a newly added feed), a manual update causes a "catchup_feed()", marking ALL of the articles read, both old unread articles and newly downloaded unread articles. This is obviously wrong. (Update: This is an adverse side effect from the manual update patch ecbd7b91fe22b9d2fe13cbe6e2483b85b400ec9b.)

I propose simply removing the catchup_feed() call entirely. See attached minor patch.

Re: Don't catchup new feed or manually updated feed

Posted: 11 Apr 2012, 21:28
by fox
Because a friend of mine thought this was annoying and after some consideration I decided this was the right way to go - reason being when you subscribe, stuff you see is not new. I found myself catching up feeds after subscription too, so this stays. :)

Re: Don't catchup new feed or manually updated feed

Posted: 11 Apr 2012, 21:46
by gmargo
fox wrote:I found myself catching up feeds after subscription too, so this stays. :)


Ok, I respect that. However I would like to separate "manual update" from "new feed" as far as this catchup. Would you agree with that? I'll figure out some way. Maybe revisit the last_update=NULL for manual update. It could just as well be the 1970 date, then it's just an SQL adjustment.

Re: Don't catchup new feed or manually updated feed

Posted: 11 Apr 2012, 23:13
by fox
A friend suggested to add a checkbox to the subscribe dialog, e.g. [x] Mark articles as read

Not sure on implementation, but probably it's simple enough, I remember adding another checkbox there.

Re: Don't catchup new feed or manually updated feed

Posted: 12 Apr 2012, 21:45
by gmargo
As promised, here is a patch to differentiate "Manual Update" from "New Feed".

With this patch a "Manual Update" will not cause a "catchup_feed()". "New Feed" behavior is unchanged.

Re: Don't catchup new feed or manually updated feed

Posted: 18 Apr 2012, 10:00
by fox
Unfortunately I was unable to review this until my vacation, will do first thing when I come back. Thanks for the patch! :D

Re: Don't catchup new feed or manually updated feed

Posted: 05 May 2012, 22:29
by fox
Thanks for the reminder, don't see anything wrong with it, so merged into trunk. Thanks!