G2TT - A Google inspired mobile interface

Development-related discussion, including bundled plugins
G2TT-mobile
Bear Rating Disaster
Bear Rating Disaster
Posts: 52
Joined: 30 Mar 2013, 00:47

Re: G2TT - A Google inspired mobile interface

Postby G2TT-mobile » 11 Aug 2013, 00:13


G2TT-mobile
Bear Rating Disaster
Bear Rating Disaster
Posts: 52
Joined: 30 Mar 2013, 00:47

Re: G2TT - A Google inspired mobile interface

Postby G2TT-mobile » 11 Aug 2013, 08:53


User avatar
erikbennett
Bear Rating Trainee
Bear Rating Trainee
Posts: 20
Joined: 17 Mar 2013, 03:08
Location: Seattle, WA

Re: G2TT - A Google inspired mobile interface

Postby erikbennett » 12 Aug 2013, 20:08

Thanks for the updated read me. Definitely appreciated.

I have just started noticing something and I'm not sure where the problem is cropping up. I have all of my feeds cataloged into folders. So, say, I have a folder called "Humor" and within it, 10 feeds. I stumbled upon this by accident. If I go into the article list of the feed in the list, then click "Feeds" back to the feed list, then go into the article list of another feed on the list, click mark all items as read, then click back to the feed list... on the auto-refresh, it will mark the 15 items in both feeds as read. I tried this out on multiple feeds. So, if I have a list of three feeds, go into the 3rd feed, go back, go into the 2nd feed, go back, then go into the first feed, click "mark all items as read" then go back to the list... on the auto-refresh, it will mark 15 items read in all the feeds! I tested this out from the full tt-rss interface, and it doesn't happen.

I realize I probably didn't explain that well. Let me know if you need clarification. (I'm on 1.9 and the most recent version of G2TT)

G2TT-mobile
Bear Rating Disaster
Bear Rating Disaster
Posts: 52
Joined: 30 Mar 2013, 00:47

Re: G2TT - A Google inspired mobile interface

Postby G2TT-mobile » 13 Aug 2013, 07:56

erikbennett, nice bug find! Based on your description I can actually picture the code/reason this is happening and should be able to fix it (just have to set aside the time). The way "Mark all as read" works is it is just an array of all the articles that have been displayed. I never thought to clear the array after I minimized the page reloads, thus the array is likely not being reset to being emptied when a feed is selected. Just have to code and test; hopefully I will get to that soon for you.

I am always concerned that my lack of thorough testing/test cases will result in bugs and this is a perfect point. I have not gone through the trouble of setting up a separate environment to test, and so I don't do a lot of testing that would have mass affects on my personal list of feeds and it finally caught up to me.

User avatar
erikbennett
Bear Rating Trainee
Bear Rating Trainee
Posts: 20
Joined: 17 Mar 2013, 03:08
Location: Seattle, WA

Re: G2TT - A Google inspired mobile interface

Postby erikbennett » 13 Aug 2013, 08:02

No problemo. Glad to be able to find it. :)

G2TT-mobile
Bear Rating Disaster
Bear Rating Disaster
Posts: 52
Joined: 30 Mar 2013, 00:47

Re: G2TT - A Google inspired mobile interface

Postby G2TT-mobile » 13 Aug 2013, 09:28

Alright, such an easy fix I wasn't going to be able to sleep soundly not fixing it. Just pushed. Hope it fixes it without adding any new issues.

User avatar
erikbennett
Bear Rating Trainee
Bear Rating Trainee
Posts: 20
Joined: 17 Mar 2013, 03:08
Location: Seattle, WA

Re: G2TT - A Google inspired mobile interface

Postby erikbennett » 15 Aug 2013, 01:39

Just updated my G2TT. Looks like that fixed it. Thanks!

ttrssmailinator
Bear Rating Trainee
Bear Rating Trainee
Posts: 13
Joined: 14 May 2013, 14:17

Re: G2TT - A Google inspired mobile interface

Postby ttrssmailinator » 15 Aug 2013, 11:39

Hi,
I have another couple of observations/thoughts that I'd like to share.

Like erikbennet, I noticed the lag when removing unread feeds. Would it make sense to update the internal data structures before moving from the article view back to the category/all view?

Would it make sense to step directly back to the all view if the category view is empty? As it is now, if I read through a category (so that I eventually see "Showing 0 items") and press the Feeds button, it will take me to a completely empty category view (the header with back, reload, and settings button are visible).

For consistency, would it make sense to have the category name (e.g. humor) or "All articles" in the header, similar to having the feed/category name in the header in the article view?

Another little inconsistency: If you go into article view under "All articles", you will see a "Feeds" button taking you back to all view, but the button taking you back to all view in the category view is labeled "<< Back". (I realize that "All articles" technically goes to an article list, which has a "Feeds" button when entered from a category view)

Has the the discussion on how the reload button works in article view been closed? ;-)

G2TT-mobile
Bear Rating Disaster
Bear Rating Disaster
Posts: 52
Joined: 30 Mar 2013, 00:47

Re: G2TT - A Google inspired mobile interface

Postby G2TT-mobile » 17 Aug 2013, 07:52


dahamsta
Bear Rating Trainee
Bear Rating Trainee
Posts: 1
Joined: 10 Oct 2013, 17:11

Re: G2TT - A Google inspired mobile interface

Postby dahamsta » 10 Oct 2013, 17:22


mrjeremy
Bear Rating Trainee
Bear Rating Trainee
Posts: 3
Joined: 18 Jan 2014, 02:00

Re: G2TT - A Google inspired mobile interface

Postby mrjeremy » 18 Jan 2014, 02:10


G2TT-mobile
Bear Rating Disaster
Bear Rating Disaster
Posts: 52
Joined: 30 Mar 2013, 00:47

Re: G2TT - A Google inspired mobile interface

Postby G2TT-mobile » 02 Feb 2014, 21:20

Thanks, mrjeremy. I pushed the login stuff just now (https://github.com/g2ttrss/g2ttrss-mobi ... 53b200db03).

I do not have a multi-user environment and so the authentication flow definitely is lacking in use-case testing.

mrjeremy
Bear Rating Trainee
Bear Rating Trainee
Posts: 3
Joined: 18 Jan 2014, 02:00

Re: G2TT - A Google inspired mobile interface

Postby mrjeremy » 02 Feb 2014, 23:35

Thanks for pushing.

I've tweaked all the icons to use font-awesome ones that look really good on iPhone.
I've also tweaked the main registration and forgot password as well to be mobile friendly.

I can send what I have or make a fork on GitHub. Just need to clean up the comments and stuff.

G2TT-mobile
Bear Rating Disaster
Bear Rating Disaster
Posts: 52
Joined: 30 Mar 2013, 00:47

Re: G2TT - A Google inspired mobile interface

Postby G2TT-mobile » 09 Feb 2014, 06:05

Thanks again mrjeremy.

I merged in your changes (minus the mudreader specific stuff).

rudy
Bear Rating Trainee
Bear Rating Trainee
Posts: 1
Joined: 14 Dec 2014, 21:41

Re: G2TT - A Google inspired mobile interface

Postby rudy » 14 Dec 2014, 22:00



Return to “Development”

Who is online

Users browsing this forum: No registered users and 7 guests