Images cached with .png

Development-related discussion, including bundled plugins
therms
Bear Rating Trainee
Bear Rating Trainee
Posts: 7
Joined: 22 Jul 2013, 01:33

Images cached with .png

Postby therms » 08 Aug 2013, 03:03

Why are all images cached with a .png extension? https://github.com/gothfox/Tiny-Tiny-RS ... ge.php#L27

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Images cached with .png

Postby fox » 08 Aug 2013, 09:10

Because it doesn't matter.

therms
Bear Rating Trainee
Bear Rating Trainee
Posts: 7
Joined: 22 Jul 2013, 01:33

Re: Images cached with .png

Postby therms » 08 Aug 2013, 19:52

Hmm.

It matters if you want to browse the cache via a file manager, but if you don't care about that I suppose that's your reasonable prerogative.

Would you accept a pull request to name them as appropriate?

User avatar
sleeper_service
Bear Rating Overlord
Bear Rating Overlord
Posts: 884
Joined: 30 Mar 2013, 23:50
Location: Dallas, Texas

Re: Images cached with .png

Postby sleeper_service » 08 Aug 2013, 20:08

therms wrote:Hmm.

It matters if you want to browse the cache via a file manager, but if you don't care about that I suppose that's your reasonable prerogative.

Would you accept a pull request to name them as appropriate?

given that I don't view pictures with a file manager, instead, using an image viewer, which seems to be bright enough to figure out what kind of file it is, no matter what it's named.... seems like it's a non-issue.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Images cached with .png

Postby fox » 08 Aug 2013, 20:27

Manually browsing tt-rss cache somehow doesn't seem like a valid use-case to me.

therms
Bear Rating Trainee
Bear Rating Trainee
Posts: 7
Joined: 22 Jul 2013, 01:33

Re: Images cached with .png

Postby therms » 08 Aug 2013, 22:02

sleeper_service wrote:
therms wrote:Hmm.

It matters if you want to browse the cache via a file manager, but if you don't care about that I suppose that's your reasonable prerogative.

Would you accept a pull request to name them as appropriate?

given that I don't view pictures with a file manager, instead, using an image viewer, which seems to be bright enough to figure out what kind of file it is, no matter what it's named.... seems like it's a non-issue.


Non-issue to you. Surprisingly, not every one uses the same software! Shocking, I know.

fox wrote:Manually browsing tt-rss cache somehow doesn't seem like a valid use-case to me.


Okey-dokey. I'll just patch it locally. Even though it means I have to touch PHP.

User avatar
sleeper_service
Bear Rating Overlord
Bear Rating Overlord
Posts: 884
Joined: 30 Mar 2013, 23:50
Location: Dallas, Texas

Re: Images cached with .png

Postby sleeper_service » 08 Aug 2013, 22:11

therms wrote:
Non-issue to you. Surprisingly, not every one uses the same software! Shocking, I know.


get a smarter image viewer.

hell, even firefox works perfectly pointed at the directory.

I think you're losing this one.

therms
Bear Rating Trainee
Bear Rating Trainee
Posts: 7
Joined: 22 Jul 2013, 01:33

Re: Images cached with .png

Postby therms » 08 Aug 2013, 22:28

sleeper_service wrote:
therms wrote:
Non-issue to you. Surprisingly, not every one uses the same software! Shocking, I know.


get a smarter image viewer.

hell, even firefox works perfectly pointed at the directory.

I think you're losing this one.


Losing?

User avatar
sleeper_service
Bear Rating Overlord
Bear Rating Overlord
Posts: 884
Joined: 30 Mar 2013, 23:50
Location: Dallas, Texas

Re: Images cached with .png

Postby sleeper_service » 08 Aug 2013, 22:45

therms wrote:Losing?

how about "lost it with your ridiculous questions and demands"

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Images cached with .png

Postby fox » 08 Aug 2013, 23:35

therms wrote:Even though it means I have to touch PHP.


Oy-vey.

therms
Bear Rating Trainee
Bear Rating Trainee
Posts: 7
Joined: 22 Jul 2013, 01:33

Re: Images cached with .png

Postby therms » 11 Aug 2013, 05:28

I found a "valid" use case where this is an issue.

Right-click save an image. Firefox and Chrome on Ubuntu and Fedora want to save image as 'image.php'.

Ctrl-drag image to desktop (which saves image instead of link) saves image as 'image.php'.

Of course, this is less of an issue with the extension and more an issue with the way the image is served.

sleeper_service wrote:
therms wrote:Losing?

how about "lost it with your ridiculous questions and demands"

This isn't a competition. I didn't demand anything, I inquired as to the reason things are the way they are, and received a reasonable response from fox.

There's something wrong with you, please let the grown ups speak.

User avatar
sleeper_service
Bear Rating Overlord
Bear Rating Overlord
Posts: 884
Joined: 30 Mar 2013, 23:50
Location: Dallas, Texas

Re: Images cached with .png

Postby sleeper_service » 11 Aug 2013, 05:56

therms wrote:
There's something wrong with you, please let the grown ups speak.


I'm just here to make fox look good, so, shut up, or I'll shut you up! :lol:


Return to “Development”

Who is online

Users browsing this forum: No registered users and 2 guests