Page 1 of 1

Images cached with .png

Posted: 08 Aug 2013, 03:03
by therms
Why are all images cached with a .png extension? https://github.com/gothfox/Tiny-Tiny-RS ... ge.php#L27

Re: Images cached with .png

Posted: 08 Aug 2013, 09:10
by fox
Because it doesn't matter.

Re: Images cached with .png

Posted: 08 Aug 2013, 19:52
by therms
Hmm.

It matters if you want to browse the cache via a file manager, but if you don't care about that I suppose that's your reasonable prerogative.

Would you accept a pull request to name them as appropriate?

Re: Images cached with .png

Posted: 08 Aug 2013, 20:08
by sleeper_service
therms wrote:Hmm.

It matters if you want to browse the cache via a file manager, but if you don't care about that I suppose that's your reasonable prerogative.

Would you accept a pull request to name them as appropriate?

given that I don't view pictures with a file manager, instead, using an image viewer, which seems to be bright enough to figure out what kind of file it is, no matter what it's named.... seems like it's a non-issue.

Re: Images cached with .png

Posted: 08 Aug 2013, 20:27
by fox
Manually browsing tt-rss cache somehow doesn't seem like a valid use-case to me.

Re: Images cached with .png

Posted: 08 Aug 2013, 22:02
by therms
sleeper_service wrote:
therms wrote:Hmm.

It matters if you want to browse the cache via a file manager, but if you don't care about that I suppose that's your reasonable prerogative.

Would you accept a pull request to name them as appropriate?

given that I don't view pictures with a file manager, instead, using an image viewer, which seems to be bright enough to figure out what kind of file it is, no matter what it's named.... seems like it's a non-issue.


Non-issue to you. Surprisingly, not every one uses the same software! Shocking, I know.

fox wrote:Manually browsing tt-rss cache somehow doesn't seem like a valid use-case to me.


Okey-dokey. I'll just patch it locally. Even though it means I have to touch PHP.

Re: Images cached with .png

Posted: 08 Aug 2013, 22:11
by sleeper_service
therms wrote:
Non-issue to you. Surprisingly, not every one uses the same software! Shocking, I know.


get a smarter image viewer.

hell, even firefox works perfectly pointed at the directory.

I think you're losing this one.

Re: Images cached with .png

Posted: 08 Aug 2013, 22:28
by therms
sleeper_service wrote:
therms wrote:
Non-issue to you. Surprisingly, not every one uses the same software! Shocking, I know.


get a smarter image viewer.

hell, even firefox works perfectly pointed at the directory.

I think you're losing this one.


Losing?

Re: Images cached with .png

Posted: 08 Aug 2013, 22:45
by sleeper_service
therms wrote:Losing?

how about "lost it with your ridiculous questions and demands"

Re: Images cached with .png

Posted: 08 Aug 2013, 23:35
by fox
therms wrote:Even though it means I have to touch PHP.


Oy-vey.

Re: Images cached with .png

Posted: 11 Aug 2013, 05:28
by therms
I found a "valid" use case where this is an issue.

Right-click save an image. Firefox and Chrome on Ubuntu and Fedora want to save image as 'image.php'.

Ctrl-drag image to desktop (which saves image instead of link) saves image as 'image.php'.

Of course, this is less of an issue with the extension and more an issue with the way the image is served.

sleeper_service wrote:
therms wrote:Losing?

how about "lost it with your ridiculous questions and demands"

This isn't a competition. I didn't demand anything, I inquired as to the reason things are the way they are, and received a reasonable response from fox.

There's something wrong with you, please let the grown ups speak.

Re: Images cached with .png

Posted: 11 Aug 2013, 05:56
by sleeper_service
therms wrote:
There's something wrong with you, please let the grown ups speak.


I'm just here to make fox look good, so, shut up, or I'll shut you up! :lol: