Page 1 of 1

Public RSS Feed

Posted: 18 Oct 2013, 03:41
by psjbeisler
I noticed my published articles were being rendered funny, specifically with images, after a few tweaks, I'd kinda like to submit a change;

atom-to-html.xsl

Ugly layout:

Code: Select all

                <xsl:for-each select="atom:entry">
                        <h2><a target="_new" href="{atom:link/@href}"><xsl:value-of select="atom:title"/></a></h2>

                         <div name="decodeme" class="content">

                               <xsl:value-of select="atom:content" disable-output-escaping="yes"/>
                        </div>

                        <xsl:if test="enclosure">
                                <p><a href="{enclosure/@url}">Extra...</a></p>
                        </xsl:if>


Pretty layout:

Code: Select all

                <xsl:for-each select="atom:entry">
                        <div style="float: left" name="decodeme" class="content">

                        <h2><a target="_new" href="{atom:link/@href}"><xsl:value-of select="atom:title"/></a></h2>

                                <xsl:value-of select="atom:content" disable-output-escaping="yes"/>
                        </div>

                        <xsl:if test="enclosure">
                                <p><a href="{enclosure/@url}">Extra...</a></p>
                        </xsl:if>

Re: Public RSS Feed

Posted: 18 Oct 2013, 04:13
by psjbeisler
I submitted a commit actually. First time having to actually do it. Cant delete the post though. Feedback is still welcome.
https://github.com/psjbeisler/Tiny-Tiny ... 709e48b73b

Re: Public RSS Feed

Posted: 18 Oct 2013, 09:11
by fox
>I submitted a commit actually.

Five times, I think.

Maybe you should post screenshots, because the feeds render fine for me. One before and one after screenshot is enough, though, five is not necessary.

Re: Public RSS Feed

Posted: 18 Oct 2013, 14:57
by psjbeisler
fox wrote:>I submitted a commit actually.

Five times, I think.

Maybe you should post screenshots, because the feeds render fine for me. One before and one after screenshot is enough, though, five is not necessary.


I did mention it was my first time using Github right? :D

Before:
Image

After:
Image

The "float:left" in div might not be the best way to call that but, it works

Re: Public RSS Feed

Posted: 19 Oct 2013, 23:38
by fox
Image

I dunno. Seems to work fine here.

Re: Public RSS Feed

Posted: 21 Oct 2013, 06:11
by psjbeisler
try with more photos maybe? cant just be me, either way wouldnt it be better to keep headers with the content and keep it clean?

Re: Public RSS Feed

Posted: 21 Oct 2013, 06:46
by levito
Since we don't know if there are floated elements inside articles (like the images in your example), we have to clearfix the div.content.

The easiest and most reliable would be an overflow: hidden here. I'll make a pull request.