dojo version

[nameless]

started toying around with dojo toolkit today.
i've been wondering why ttrss still is at 1.8.3?
is updating dojo a pain in the ass?
this is not exactly ttrss development related but i figured i might post it here anyways.

[fox]

yes it is

also using it

also p much anything about it is

e: i'm not really seeing any reason to update, they did change the site but the framework seems about the same, not even a new theme

[nameless]

i just found this https://github.com/Esri/dojo-theme-flat and figured i might "port" it over to ttrss.
haven't found a good starting point yet.

edit: also i am not sure if i wanna mess with some weird nodejs stylus shit

dojo 2.0 is on its way brining typescript support and shit. i dunno if wanna start compiling javascript.

[fox]

i just did a crude 1.10.4 import and lots of stuff is broken and i'm really not gonna bother fixing it all since it all seems useless

its on gitlab if anyone is interested

i think we're stuck with this version for the time being

[fox]

this theme is not bad looking but i think i'm doing something wrong with the css files:

https://fakecake.org/uploads/2015/201507lnERcS.png

images missing, etc

e: oh im an idiot of course its fontawesome duh

[nameless]

Thats exactly how far i got until now.
I just figured it was my fault and i wasnt understanding how to dojo.

Didn't know it is fontawesome

[fox]

yeah well i did add it and its still squares so welp

[nameless]

Could you add an up to date screenshot?

[fox]

it looks exactly same

i guess one of the styles in tt-rss.css overrides it

e: yeah

it was this

Code: Select all

--- a/css/tt-rss.css
+++ b/css/tt-rss.css
@@ -356,8 +356,6 @@ div.prefHelp {
 #main-toolbar table *,
 #main-toolbar .actionChooser * {
        text-rendering: optimizelegibility;
-       font-family : "Segoe WP", "Segoe UI Web", "Segoe UI", Ubuntu, "DejaVu Sans", "Helvetica Neue",
-               Helvetica, Arial, sans-serif;
        font-size : 12px;

 }


the buttons are huuge tho they don't become smaller when in toolbar like in stock theme

[nameless]

Button size is hardcoded, seriously?

I just read they will do some optimisations and add it to dojo with 1.11 so maybe we should just wait.

Edit: referring to this https://bugs.dojotoolkit.org/ticket/18536

[fox]

nah it was me being dumb, selects apparently don't become inline in toolbars, dropdowns do

https://fakecake.org/uploads/2015/201507nxj8K7.png

well, eh

[nameless]

I kinda like how this looks

[fox]

i dunno: https://fakecake.org/uploads/2015/201507RLzQ3h.png

i'll push a branch to gitlab if you want to screw around with it but personally it looks kinda meh

e: https://tt-rss.org/gitlab/fox/tt-rss/tr ... flat-theme

[nameless]

I will mess around with it this weekend.
Preferences indeed do look ugly.
Overall this flatish thingy doesent work too well with the basic theme of ttrss.
It's probably not worth to invest too much effort into it.