Page 1 of 1

key assignments j and k are backwards

Posted: 06 Feb 2012, 23:43
by gmargo
I like the key assignments for the most part, but any "vi" user will say that "j" and "k" are backwards. "j" should be "down" (aka "next") and "k" should be "up" (aka "previous").

So I use this patch, which switches the j/k assignments. :

Code: Select all

diff --git a/js/tt-rss.js b/js/tt-rss.js
index 5804ee5..ac44b44 100644
--- a/js/tt-rss.js
+++ b/js/tt-rss.js
@@ -699,7 +699,7 @@ function hotkey_handler(e) {
             return false;
          }
 
-         if (keycode == 74 && !shift_key) { // j
+         if (keycode == 75 && !shift_key) { // k
             var rv = dijit.byId("feedTree").getPreviousFeed(
                   getActiveFeedId(), activeFeedIsCat());
 
@@ -708,7 +708,7 @@ function hotkey_handler(e) {
             return;
          }
 
-         if (keycode == 75) { // k
+         if (keycode == 74 && !shift_key) { // j
             var rv = dijit.byId("feedTree").getNextFeed(
                   getActiveFeedId(), activeFeedIsCat());
 

Re: key assignments j and k are backwards

Posted: 07 Feb 2012, 12:13
by fox
You could go one step forward and remap n/p to h/l. :)