SVG star and share icons

Request new functionality here
dotdavid
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 23 Mar 2013, 18:53

SVG star and share icons

Postby dotdavid » 23 Mar 2013, 19:44

Hi,

I know it's an ancient and rubbish web browser but my work makes me use IE8. Unfortunately it can't display SVG graphics, so the star and share icons don't show.

Would it be possible to show PNG versions of these icons to IE8 clients?

- dotdavid

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: SVG star and share icons

Postby fox » 27 Mar 2013, 10:20

There are png versions included, you can just replace svg with png in the source.

dotdavid
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 23 Mar 2013, 18:53

Re: SVG star and share icons

Postby dotdavid » 27 Mar 2013, 14:37

I guess that's a decent workaround. I think I'll look at whether I can modify the code to work with both myself, presumably I can then submit the changes as a patch.

Do you also accept contributions for new plugins?

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: SVG star and share icons

Postby fox » 27 Mar 2013, 14:44

>presumably I can then submit the changes as a patch.

Patches "because IE" are a no go, sorry.

dotdavid
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 23 Mar 2013, 18:53

Re: SVG star and share icons

Postby dotdavid » 27 Mar 2013, 14:54

That's a fair position. Maybe a theme is the way forward then. Presumably most of the issues with IE will be CSS-related and thus a theme can avoid them.

I'll have a play around and see what I can do. Would you accept a theme as a contribution?

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: SVG star and share icons

Postby fox » 27 Mar 2013, 15:03

My position on this boils down to this: I'm just one guy, MS is a huge corporation. If they can't fix their perpetually broken piece of shit browser, I sure as hell am not going to bother with it.

The correct course of action here would be asking your employer to use a browser fit for 21st century.

dotdavid
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 23 Mar 2013, 18:53

Re: SVG star and share icons

Postby dotdavid » 27 Mar 2013, 17:41

I sympathise with your position on IE, and I've tried telling my employer many times but they don't listen. So I'll have a go at a theme and if it works I'll post the code on here in case others want to use it.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: SVG star and share icons

Postby fox » 27 Mar 2013, 18:04

Yeah posting stuff is totally fine, just don't expect it in trunk that's all. :)

QuickBASIC
Bear Rating Trainee
Bear Rating Trainee
Posts: 6
Joined: 29 Mar 2013, 09:56

Re: SVG star and share icons

Postby QuickBASIC » 29 Mar 2013, 10:08

Even with the mimetypes in my .htaccess, my host still doesn't play nice with the svgs on tt-rss.

User avatar
eliotcougar
Bear Rating Trainee
Bear Rating Trainee
Posts: 13
Joined: 03 Apr 2013, 21:22
Location: Puschino, Russia
Contact:

Re: SVG star and share icons

Postby eliotcougar » 03 Apr 2013, 23:28

I hate stupid bugs... It appears that Opera 12 does not update an image after you change src attribute of an img element via JS if the src attribute contains an svg image... i.e. clicking star does add the feed article to "starred", but the star does not change its appearance even though src attribute changes in DOM...
However it does work with png images...
Curiouser and curiouser... "Smart" people from stackoverflow suggest using inline SVG in that case and change its parameters (shape, color) on-the-fly... If you really want to use SVG of-course... LOL...
BTW, you don't have PNG alternatives in latest versions anymore...

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: SVG star and share icons

Postby fox » 03 Apr 2013, 23:47

Well opera did announce switching to webkit, so this working properly is only a matter of time now. :)

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: SVG star and share icons

Postby fox » 04 Apr 2013, 09:50

btw I wonder if this will make any difference with opera (and in general make auto mark as read a bit more reliable)

https://github.com/gothfox/Tiny-Tiny-RS ... 0b3fdc3601
https://github.com/gothfox/Tiny-Tiny-RS ... 67959a3f54

User avatar
eliotcougar
Bear Rating Trainee
Bear Rating Trainee
Posts: 13
Joined: 03 Apr 2013, 21:22
Location: Puschino, Russia
Contact:

Re: SVG star and share icons

Postby eliotcougar » 04 Apr 2013, 16:21

Made those changes... Now I've been able to scroll through 200 unread items with images very quickly without the usual performance drop...
Need to observe it a little longer to exclude simple luck (ein versuch - kein versuch), but it doesn't seem to have any negative effect at least...

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: SVG star and share icons

Postby fox » 04 Apr 2013, 16:24

That is quite unexpected actually, but cool. :)

User avatar
eliotcougar
Bear Rating Trainee
Bear Rating Trainee
Posts: 13
Joined: 03 Apr 2013, 21:22
Location: Puschino, Russia
Contact:

Re: SVG star and share icons

Postby eliotcougar » 06 Apr 2013, 16:35

fox wrote:That is quite unexpected actually, but cool. :)

Okay, some testing and update to 1.7.8 showed that the problem was not with DOM, but with SVG... I've got SVG icons back after the update, and feed scrolling was slow again... I changed them to PNG in feeds.php, and everything is fast again...
Probably, Opera has some other issues with "SVG inside IMG", than just inability to replace them dynamically with JS...


Return to “Feature requests”

Who is online

Users browsing this forum: No registered users and 10 guests