about Headline display mode,Swipe and Volume Key

Request new functionality here
nameless
Bear Rating Master
Bear Rating Master
Posts: 126
Joined: 28 Aug 2013, 20:33

Re: about Headline display mode,Swipe and Volume Key

Postby nameless » 08 Jul 2015, 16:15

Looks great.
Is it possible to access the "gallery" by clicking on the icon or will it select the article?

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: about Headline display mode,Swipe and Volume Key

Postby fox » 08 Jul 2015, 16:44

for the sake of consistency it probably should function in the same fashion as the textdrawable, not sure how to fit the picture pager in there

e: vvvv i put it on longtap so nobody would ever find it

nameless
Bear Rating Master
Bear Rating Master
Posts: 126
Joined: 28 Aug 2013, 20:33

Re: about Headline display mode,Swipe and Volume Key

Postby nameless » 08 Jul 2015, 16:58

Something like doubleclicking the picture?

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: about Headline display mode,Swipe and Volume Key

Postby fox » 08 Jul 2015, 18:14

beta should be up in a few hours

atrus
Bear Rating Trainee
Bear Rating Trainee
Posts: 17
Joined: 19 Apr 2013, 20:03

Re: about Headline display mode,Swipe and Volume Key

Postby atrus » 09 Jul 2015, 04:41

What about using the "favicon" as the image? That would provide a little actual information.

Maru
Bear Rating Trainee
Bear Rating Trainee
Posts: 40
Joined: 20 Oct 2013, 14:26

Re: about Headline display mode,Swipe and Volume Key

Postby Maru » 09 Jul 2015, 08:18

fox wrote:beta should be up in a few hours


I really like the new look with the images in the circle.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: about Headline display mode,Swipe and Volume Key

Postby fox » 09 Jul 2015, 08:30

atrus wrote:What about using the "favicon" as the image? That would provide a little actual information.


we're not placing horribly stretched 16x16px bitmaps on screen

randompherret
Bear Rating Trainee
Bear Rating Trainee
Posts: 36
Joined: 04 Jul 2013, 08:11

Re: about Headline display mode,Swipe and Volume Key

Postby randompherret » 09 Jul 2015, 16:06

If a feed only has one image and it very short it stretches it out. from feed: http://www.fark.com/geek/fark.rss

otherwise it does look very nice.
Attachments
Screenshot_2015-07-09-08-02-55.png
Screenshot_2015-07-09-08-02-55.png (343.07 KiB) Viewed 3015 times

Maru
Bear Rating Trainee
Bear Rating Trainee
Posts: 40
Joined: 20 Oct 2013, 14:26

Re: about Headline display mode,Swipe and Volume Key

Postby Maru » 09 Jul 2015, 16:39

Hello Fox,

I noticed a corner case with several feeds I have here. For licensing reasons these feeds do not show images in the rss feed but they STILL include pictures with a width and height of 1 though. The current code for the badge creation uses these pictures which then results in no badge been shown.
I monkey patched the if statement in the headlinesfragment to check for images which define a very small height and then force the usage of the textDrawable. I am pretty sure there is more elegant code to do this.

Code: Select all

...
String imgHeight = item.flavorImage.attr("height");
Integer height = 10;

if (!imgHeight.isEmpty()) {
    height = Integer.parseInt(imgHeight);
}

if (item.flavorImage == null || height < 10 ) {
.....

Maru
Bear Rating Trainee
Bear Rating Trainee
Posts: 40
Joined: 20 Oct 2013, 14:26

Re: about Headline display mode,Swipe and Volume Key

Postby Maru » 09 Jul 2015, 22:53

Edit: Argh of course this is not really working since flavorImage might indeed be NULL so I changed this a little bit

Code: Select all

if (item.flavorImage == null) {
  holder.textImage.setImageDrawable(textDrawable);
  holder.textImage.setTag(null);
} else {
  String imgHeight = item.flavorImage.attr("height");
  Integer height = imgHeight.isEmpty() ? 10 : Integer.parseInt(imgHeight);

  if (height < 10) {
    holder.textImage.setImageDrawable(textDrawable);
    holder.textImage.setTag(null);
  } else {
  ...


This still does not help if the width and height is given in percent which is still valid.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: about Headline display mode,Swipe and Volume Key

Postby fox » 10 Jul 2015, 01:11

yeah there's a minimum size enforced for normal flavor images, i guess there could be some (smaller) requirement for tiny thumbnails

anyway, i made another thing which kinda-sorta works with various caveats:

Image

yeah its a video player


Return to “Feature requests”

Who is online

Users browsing this forum: No registered users and 3 guests