Cached images in generated feeds

Request new functionality here
Oxides
Bear Rating Trainee
Bear Rating Trainee
Posts: 3
Joined: 11 Feb 2016, 19:00

Cached images in generated feeds

Postby Oxides » 11 Feb 2016, 19:05

I am using the plugin that caches images in starred articles, but when I generate a feed from my starred articles it doesn't use the cached images. For many old articles this means that the images are broken if the original has been removed. I dug through the FAQ about generated feeds but didn't find a switch I may be missing. Is there an easy way to do this that I might have missed?

JustAMacUser
Bear Rating Overlord
Bear Rating Overlord
Posts: 373
Joined: 20 Aug 2013, 23:13

Re: Cached images in generated feeds

Postby JustAMacUser » 11 Feb 2016, 20:04

It looks like the cached_starred_images plugin needs to be passed an article ID so it knows the file name for the cached image. The code that generates the shared feed (for starred articles in your case) doesn't pass the ID. This should be an easy patch, but I'm away from my computer at the moment. You could edit line 143 of public.php to pass more information to sanitize(). I'm thinking that should fix it. If you're not familiar with PHP, I don't recommend making changes though.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Cached images in generated feeds

Postby fox » 11 Feb 2016, 20:12

yep it's an easy fix, thanks for investigating

should be fixed in 3261dbf.

Oxides
Bear Rating Trainee
Bear Rating Trainee
Posts: 3
Joined: 11 Feb 2016, 19:00

Re: Cached images in generated feeds

Postby Oxides » 11 Feb 2016, 20:26

Thanks guys. TT-RSS is a pretty phenomenal application. I'll keep an eye out for the update.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Cached images in generated feeds

Postby fox » 11 Feb 2016, 23:07

unless you're using git you're in for quite a wait

Oxides
Bear Rating Trainee
Bear Rating Trainee
Posts: 3
Joined: 11 Feb 2016, 19:00

Re: Cached images in generated feeds

Postby Oxides » 11 Feb 2016, 23:44

I'm using git, I just don't update that frequently. I should probably have said "I'll try updating it in a couple of days."


Return to “Feature requests”

Who is online

Users browsing this forum: No registered users and 6 guests