Feeds with updates disabled still updating

Development-related discussion, including bundled plugins
ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Feeds with updates disabled still updating

Postby ajs124 » 31 Mar 2016, 00:36


User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 31 Mar 2016, 07:52

its possible that the enabled feed is selected for update and then it runs all feeds w/ the same url not checking their update_interval

i'll take a look

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 31 Mar 2016, 20:02

i suggest you collect update daemon logs which mention the disabled feed being updated, not sure what to tell you tbh

ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Re: Feeds with updates disabled still updating

Postby ajs124 » 31 Mar 2016, 21:49


User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 31 Mar 2016, 22:16

well that's not supposed to happen i think

mysql or postgres? also: versions of everything including tt-rss

ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Re: Feeds with updates disabled still updating

Postby ajs124 » 01 Apr 2016, 01:23


User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 01 Apr 2016, 07:37

btw you sure you're not double clicking any of the disabled feeds? that might either queue (i.e. set last_updated to 1970-01-01) or directly update one in background

ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Re: Feeds with updates disabled still updating

Postby ajs124 » 01 Apr 2016, 12:42

I was not aware of the fact that double clicking would cause an update, but I'm >90% certain, that that's not the problem. There were, for example, new entries from those feeds in my reader this morning which were added between me last opening tt-rss and that morning and I did not double click the feed this morning.

Since the client side can apparently trigger an update: I'm also using the official android app. And for the webinterface my client is the most recent stable firefox release (45.0.1).

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 01 Apr 2016, 13:01

well the feeds with the update_interval set to -1 are specifically excluded from any automated update processes (unless last_updated is "never") so i'm not sure what could be causing this tbh

you can try temporarily commenting out the block starting with if ($any_needs_curl) in classes/feeds.php:188 but it probably won't help

e: you can also email me your database dump i guess

ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Re: Feeds with updates disabled still updating

Postby ajs124 » 01 Apr 2016, 18:04

Commenting out that code in feeds.php does not seem to have helped.

About the feeds being excluded: how are feeds and their updates separated between different users? I suspect this problem arises somehow because there are multiple users with the exact same feed…

I will send you a database dump after I got the permission/consent from the other users on my server.

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 01 Apr 2016, 18:40

>I suspect this problem arises somehow because there are multiple users with the exact same feed…

no shit

you can see the relevant queries for yourself in rssfuncs.php

e: nevermind the database, looks like i replicated this here

User avatar
fox
^ me reading your posts ^
Posts: 6318
Joined: 27 Aug 2005, 22:53
Location: Saint-Petersburg, Russia
Contact:

Re: Feeds with updates disabled still updating

Postby fox » 01 Apr 2016, 18:56

this should be fixed in current git (unless i broke everything)

ajs124
Bear Rating Trainee
Bear Rating Trainee
Posts: 10
Joined: 28 Mar 2013, 06:49

Re: Feeds with updates disabled still updating

Postby ajs124 » 02 Apr 2016, 13:19

Yup, seems to work now. Thanks for writing and maintaining tt-rss.


Return to “Development”

Who is online

Users browsing this forum: No registered users and 7 guests