I did not like how the mail plugin would take the sender address (From header) from config.php. So I changed it to use the users name and email address.
It was a very simple change in the init.php:
185c185
< $mail->AddReplyTo(strip_tags($_REQUEST['from_email']),
---
> $mail->setFrom(strip_tags($_REQUEST['from_email']),
Can this change be put into the official source? How do I submit it to the maintainers?
mail plugin sender address
- fox
- ^ me reading your posts ^
- Posts: 6318
- Joined: 27 Aug 2005, 22:53
- Location: Saint-Petersburg, Russia
- Contact:
Re: mail plugin sender address
tripping email spoofing protection everywhere sounds like a great idea, op
- sleeper_service
- Bear Rating Overlord
- Posts: 884
- Joined: 30 Mar 2013, 23:50
- Location: Dallas, Texas
Re: mail plugin sender address
bjorn, since you seem a bit slow... I'll translate what fox said:
NO
NO
Re: mail plugin sender address
Ok, fair call fox about the email spoofing, altho does email spoofing protection trigger only the envelope or the headers too? I am thinking for example SPF only uses the envelope?
Even if the "From:" header could have the users name rather than "Tiny Tiny RSS" would look better to the recipient... but that is just personal opinion. e.g. From: Joe User <[email protected]>
To resolve this for me personally I will copy the mail plugin to a new plugin name/folder so my changes don't get wiped by a future git update.
Thanks.
Even if the "From:" header could have the users name rather than "Tiny Tiny RSS" would look better to the recipient... but that is just personal opinion. e.g. From: Joe User <[email protected]>
To resolve this for me personally I will copy the mail plugin to a new plugin name/folder so my changes don't get wiped by a future git update.
Thanks.
- fox
- ^ me reading your posts ^
- Posts: 6318
- Joined: 27 Aug 2005, 22:53
- Location: Saint-Petersburg, Russia
- Contact:
Re: mail plugin sender address
i dunno about from name, it is still more or less spoofing and might trip overzealous filters of something like outlook.com
having a separate plugin copy is a good idea
having a separate plugin copy is a good idea
Return to “Themes and plugins”
Who is online
Users browsing this forum: No registered users and 1 guest